Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapMembershipDestroy to top of deletions in updateMap function #59

Merged
merged 1 commit into from
May 20, 2024
Merged

MapMembershipDestroy to top of deletions in updateMap function #59

merged 1 commit into from
May 20, 2024

Conversation

ms0ur1s
Copy link
Contributor

@ms0ur1s ms0ur1s commented May 17, 2024

What? Why?

Minor refactor with the aim of preventing further instances of #58

@ms0ur1s ms0ur1s requested a review from rogup May 17, 2024 13:54
@ms0ur1s ms0ur1s mentioned this pull request May 17, 2024
Open
rogup
rogup approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@rogup rogup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@rogup rogup merged commit 39a8bdf into development May 20, 2024
2 checks passed
@rogup rogup deleted the 58-move-map-memberships-destroy branch May 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogup rogup rogup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ms0ur1s @rogup